Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Experimental function to convert a list of events to DataFrame.
Requires the installation of additional packages.
The
pandas
package is not, and will not, be a dependency ofthe core
disruptive
package. However, supporting DataFrames is asignificant enough convenience that we're experimenting with it here.
May be removed in the future if we decide that this is not a good idea.
The columns
device_id
,event_id
, andevent_type
are static, thenone additional column is concatenated for every eventData field.
Changes to EventHistory.list_events()
Before:
EventHistory.list_events()
output waslist[Event]
.Now:
EventHistory.list_events()
output isEventHistory
, the instance of a class that itself inherits thelist
type. This allows us to add functionality liketo_dataframe()
while preserving all the previous behavior expected from alist
.For an
list_events()
outputevents
, the checkstill holds and should not affect previous implementations.