[BUG] 404 when trying to "Add as redirect" in "Failures"

[ieteo]

Describe the bug

The release 4.2.0 fixed the bug #300 when editing or removing path containing slashes from "Routes". Thank you!

However, the bug is still present when trying to "Add as redirect" from "Failures", which results in 404 error as described in #300

This bug is only present on Apache when the AllowEncodedSlashes is set to Off

Steps to reproduce

1. Get the Kirby starter kit and instal distantnative/retour-for-kirby

git clone https://github.com/getkirby/starterkit.git
cd starterkit
composer require distantnative/retour-for-kirby

2. Create Dockerfile with following content

FROM php:8.1-apache
RUN a2enmod rewrite

3. Build image and run the container

docker build -t starterkit .
docker run -p 80:80 -v "$PWD":/var/www/html starterkit

4. Call a non-existent URL containing slashes e.g. http://localhost/sub/not-existing
5. Go to http://localhost/panel, create user and log in
6. Go to Rredirect > Failures and Add as redirect the previously called non-existent URL

Result:
404 Not Found from Apache

Note
Removing path containing slashes under Failures also results in 404 error

Expected behavior

modal opens up in order to add the path as redirect

Context

• Kirby version: 3.7.5
• Retour version: 4.2.0
• Web Server: Apache with AllowEncodedSlashes Off

[distantnative]

🙈

[ieteo]

I assume that changing this line:

retour-for-kirby/src/panel/components/Tabs/FailuresTab.vue

Line 65 in b74f547

const path = encodeURIComponent(row.path);

to:
const path = encodeURIComponent(row.path.replace(/\//g, "\x1D"));

as what was done in:

retour-for-kirby/src/panel/components/Tabs/RedirectsTab.vue

Line 103 in b74f547

const id = encodeURIComponent(row.from.replace(/\//g, "\x1D"));

would hopefully also fix it in FailuresTab

EDIT:

The above alone won fix the issue.

In order to fix it, I had to changed the above and also change this line:

retour-for-kirby/src/extensions/dialogs.php

Line 142 in b74f547

'from' => urldecode($path)

to:
'from' => str_replace("\x1D",'/', urldecode($path))

[distantnative]

✅