Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove the jobs limit #452

Closed
curoky opened this issue Jan 14, 2022 · 1 comment
Closed

Please remove the jobs limit #452

curoky opened this issue Jan 14, 2022 · 1 comment

Comments

@curoky
Copy link

curoky commented Jan 14, 2022

We recently purchased a batch of AMD machines which has 192 cores.

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
Address sizes:       43 bits physical, 48 bits virtual
CPU(s):              192
On-line CPU(s) list: 0-191
Thread(s) per core:  2
Core(s) per socket:  48
Socket(s):           2
NUMA node(s):        8
Vendor ID:           AuthenticAMD
CPU family:          23
Model:               49
Model name:          AMD EPYC 7642 48-Core Processor
Stepping:            0
CPU MHz:             3286.425
CPU max MHz:         2300.0000
CPU min MHz:         1500.0000
BogoMIPS:            4591.38
Virtualization:      AMD-V
L1d cache:           32K
L1i cache:           32K
L2 cache:            512K
L3 cache:            16384K
NUMA node0 CPU(s):   0-11,96-107
NUMA node1 CPU(s):   12-23,108-119
NUMA node2 CPU(s):   24-35,120-131
NUMA node3 CPU(s):   36-47,132-143
NUMA node4 CPU(s):   48-59,144-155
NUMA node5 CPU(s):   60-71,156-167
NUMA node6 CPU(s):   72-83,168-179
NUMA node7 CPU(s):   84-95,180-191

For improving CPU usage, we need set the --jobs to n*core which will trigger a limit of 200.

distcc/src/dopt.c

Lines 311 to 316 in fae8362

case 'j':
if (arg_max_jobs < 1 || arg_max_jobs > 200) {
rs_log_error("--jobs argument must be between 1 and 200");
exitcode = EXIT_BAD_ARGUMENTS;
goto out_exit;
}

Could this check be removed?

00gh pushed a commit to 00gh/distcc that referenced this issue Mar 27, 2022
00gh pushed a commit to 00gh/distcc that referenced this issue Mar 31, 2022
@andy5995
Copy link

andy5995 commented Sep 3, 2022

Looks like this ticket can be closed

@curoky curoky closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants