fix Issue #145. Allow -j (jobs) param to set number slots when used in zeroconf mode. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfont
force-pushed
the
zeroconf-jobs-parameter
branch
5 times, most recently
from
ea46a75
to
6e8300f
Compare
|
I forced updated this PR's commit so that I'm using the word "jobs" to refer to the maximum number of jobs per host, instead of using the word "slots". |
If server is started in zeroconf mode, the previous behavior was that the number of jobs for any server was hardcoded to 4 * number of cpus. This commit allows distccd to be invoked in zeroconf mode with the -j parameter to specify n_jobs, the maximum number of concurrent jobs for this server. If no -j is specified, then this host will publish its n_jobs to be 2 * number of cores + 2. (Note: this is the same behavior as when invoking a non-zerconf server without specifying -j.) To maintain backward compatibily, if a distccd zeroconf server doesn't publish a value for n_jobs, then it will be assigned a default n_jobs equal to the previous behavior of 4 * number of cores.
ericfont
force-pushed
the
zeroconf-jobs-parameter
branch
from
6e8300f
to
47d0e48
Compare
|
Thank you. As this looks to be a helpful extension of existing functionality I am happy to merge in the request. No one else has issued any objections in the last week either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If server is started in zeroconf mode, the previous behavior was that the number of slots for any server was hardcoded to 4 * number of cpus. This made zeroconf impracticle when different hosts had different core counts.
This commit allows distccd to be invoked in zeroconf mode with the -j parameter to specify total slots for the particular server being invoked.
If no -j specified, then this host will publish its total number of slots to be 2 * number of cores + 2. (Note: this is the same behavior as when invoking a non-zerconf server without specifying -j.)
To maintain backward compatibily, if a distccd zeroconf server doesn't publish a value for slots, then it will be assigned a default total slots equal to the previous behavior of 4 * number of cores.
Note that the meaning of "slots" in the code now always refers to the number of slots per host. (The previous interepration of "slots" was inconsistent, because sometimes it meant the number of slots per core.)