Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix desktop spec compliance of distccmon-gnome install #319

Merged
merged 1 commit into from Sep 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions Makefile.in
Expand Up @@ -52,13 +52,14 @@ mandir = @mandir@
includedir = @includedir@
oldincludedir = /usr/include
docdir = @docdir@
pkgdatadir = $(datadir)/@PACKAGE_NAME@
icondir = $(datarootdir)/pixmaps
desktopdir = $(datarootdir)/applications

include_server_builddir = $(builddir)/_include_server

# These must be done from here, not from autoconf, because they can
# contain variable expansions written in Make syntax. Ew.
DIR_DEFS = -DLIBDIR="\"${libdir}\"" -DSYSCONFDIR="\"${sysconfdir}\"" -DPKGDATADIR="\"${pkgdatadir}\""
DIR_DEFS = -DLIBDIR="\"${libdir}\"" -DSYSCONFDIR="\"${sysconfdir}\"" -DICONDIR="\"${icondir}\""

# arguments to pkgconfig
GNOME_PACKAGES = @GNOME_PACKAGES@
Expand Down Expand Up @@ -387,7 +388,7 @@ man_HTML = man/distcc_1.html man/distccd_1.html man/distccmon_text_1.html \
man/lsdistcc_1.html man/pump_1.html man/include_server_1.html
MEN = $(man1_MEN)

gnome_data = gnome/distccmon-gnome-icon.png \
gnome_data = gnome/distccmon-gnome.png \
gnome/distccmon-gnome.desktop

popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \
Expand Down Expand Up @@ -1033,7 +1034,8 @@ showpaths:
@echo " programs $(DESTDIR)$(bindir)"
@echo " sbin programs $(DESTDIR)$(sbindir)"
@echo " system configuration $(DESTDIR)$(sysconfdir)"
@echo " shared data files $(DESTDIR)$(pkgdatadir)"
@echo " icon file $(DESTDIR)$(icondir)"
@echo " application file $(DESTDIR)$(desktopdir)"


# install-sh can't handle multiple arguments, but we don't need any
Expand Down Expand Up @@ -1129,10 +1131,10 @@ install-example: $(example_DOCS)
done

install-gnome-data: $(gnome_data)
$(mkinstalldirs) "$(DESTDIR)$(pkgdatadir)"
for p in $(gnome_data); do \
$(INSTALL_DATA) "$$p" "$(DESTDIR)$(pkgdatadir)" || exit 1; \
done
$(mkinstalldirs) "$(DESTDIR)$(icondir)"
$(mkinstalldirs) "$(DESTDIR)$(desktopdir)"
$(INSTALL_DATA) gnome/distccmon-gnome.png "$(DESTDIR)$(icondir)"
$(INSTALL_DATA) gnome/distccmon-gnome.desktop "$(DESTDIR)$(desktopdir)"

install-conf: $(conf_files) $(default_files)
$(mkinstalldirs) "$(DESTDIR)$(sysconfdir)/distcc"
Expand Down
7 changes: 3 additions & 4 deletions gnome/distccmon-gnome.desktop
@@ -1,16 +1,15 @@
[Desktop Entry]
Version=0.9.4
Encoding=UTF-8
Version=1.0
Exec=distccmon-gnome
Name=distcc monitor
Name[sv]=distcc övervakare
GenericName=Distributed Compile Monitor
GenericName[sv]=Distribuerad kompilerings-övervakare
Comment=Graphical view of distributed compile tasks
Comment[sv]=Grafisk vy av distribuerade kompileringsuppgifter
Icon=distccmon-gnome-icon.png
Icon=distccmon-gnome
TryExec=distccmon-gnome
Terminal=false
Type=Application
Categories=GNOME;Application;Development;
Categories=GNOME;GTK;Development;
StartupNotify=true
File renamed without changes
2 changes: 1 addition & 1 deletion src/mon-gnome.c
Expand Up @@ -599,7 +599,7 @@ static GtkWidget * dcc_gnome_make_mainwin (void)

#if GTK_CHECK_VERSION(2,2,0)
gtk_window_set_icon_from_file (GTK_WINDOW (mainwin),
PKGDATADIR "/distccmon-gnome-icon.png",
ICONDIR "/distccmon-gnome.png",
NULL);
#endif

Expand Down