New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update field names in Product.item components #63

Closed

4 tasks done

madcalf opened this issue Jun 6, 2024 · 0 comments · Fixed by #64

Closed

4 tasks done

Update field names in Product.item components #63

madcalf opened this issue Jun 6, 2024 · 0 comments · Fixed by #64

Assignees

Contributor

madcalf commented Jun 6, 2024 •

edited

Loading

Update the Product.info components' field names to be more consistent and/or clarify their intent

in the volume component, rename volumeUnit to packageVolumeUnit to be consistent with the weight component
in the volume, weight, value, components, change xxxSource to just source
in the value component, change price, count, and pricePerUnit to packagePrice, countPerPackage, and itemPrice to align with volume & weight components
change field names to camelCase in value and needs_met components

The text was updated successfully, but these errors were encountered:

madcalf self-assigned this

madcalf mentioned this issue

Fix: update Product.item components #64

Merged

jtfairbank closed this as completed in #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment