-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update Product.item components #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Praise: Great job touching up all of the documented consistency issues!
- Suggestion (blocking): Noticed a few others while I was reviewing. Can we address them in this PR too?
- for
item.needsMet
, renamemonthlyNeedsMetPerUnit
tomonthlyNeedsMetPerItem
so that we're using the item / unit terminology consistently - for
item.value
make thesource
andlogDate
fields required, to be consistent withitem.volume
anditem.weight
- for
- Question: For
item.value
, do you think it'd be worth adding apackagePriceUnit
field, set toUSD
as a constant for now? And what about namingitemPrice
toitemPriceUSD
for consistency withitemVolume
anditemWeight
which include units in the field name?
@madcalf testing 123 |
Rename is done. Will make |
Sure that makes sense. Added it as an enum with |
Renamed itemPrice to |
1da3560
to
b3e3e96
Compare
@madcalf looks great! |
Updates the
Product.info
components' field names to be more consistent and/or clarify their intent.Also removes the default values in the
weight
component.Closes #63