Region Page Shipment Totals & Formatting #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Changes to your CodeSee Architecture Map:View this PR diagram as an interactive map View more CodeSee Maps Legend |
hola-soy-milk
changed the title
hola-soy-milk
added
enhancement
jtfairbank
reviewed
Oct 21, 2021
| @@ -41,6 +53,25 @@ const RegionPageTemplate: FunctionComponent<Props> = ({ data }) => { | |||
| [], | |||
| ) | |||
|
|
|||
| const totals: Totals = allShipments.reduce( | |||
There was a problem hiding this comment.
Future: Would be good to refactor this into a utility function so we can consistently calculate totals across multiple shipments anywhere in the codebase.
There was a problem hiding this comment.
Well put, thanks for the feedback!
|
Latest recording: |
jtfairbank
approved these changes
Oct 21, 2021
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24, was originally PR #26, which we've rebased to avoid conflicts
Progress: