This repository has been archived by the owner on Jul 17, 2022. It is now read-only.
Add end-to-end test runner to frontend #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbyheart
force-pushed
the
frontend-e2e-tests
branch
2 times, most recently
from
cdbc1df
to
3edfe21
Compare
coderbyheart
force-pushed
the
frontend-e2e-tests
branch
from
31f8345
to
8cd8a70
Compare
coderbyheart
force-pushed
the
frontend-e2e-tests
branch
from
8cd8a70
to
b3177cb
Compare
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
deammer
reviewed
Jan 6, 2022
Comment on lines
+7
to
+15
| export const frontend = (app: Express) => { | ||
| const root = path.join(process.cwd(), 'frontend', 'build') | ||
| console.debug(`ℹ️ Frontend web application hosted from`, root) | ||
| app.use(staticWebsite(root)) | ||
| // All other requests are handled by the index.html | ||
| const spaIndex = path.join(root, 'index.html') | ||
| app.get('*', (_, res) => { | ||
| res.sendFile(spaIndex) | ||
| }) |
deammer
approved these changes
Jan 6, 2022
|
The cool part is that it also creates screenshots, so one can also visually inspect the website. |
coderbyheart
force-pushed
the
frontend-e2e-tests
branch
from
73d31c0
to
fb1f985
Compare
This implements end-to-end-tests using Playwright. See https://playwright.dev/ This ensures that our frontend runs and that dependency update PRs can safely be merged.
coderbyheart
force-pushed
the
frontend-e2e-tests
branch
from
fb1f985
to
bd16a7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements end-to-end-tests using Playwright.
See https://playwright.dev/
This ensures that our frontend runs and that dependency update PRs can safely be merged.
run inspector from inside Docker container: https://www.geeksforgeeks.org/running-gui-applications-on-docker-in-linux/