New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for indexing SAR data into elasticsearch 1.7.x #176
Conversation
okay it seems I forgot about the indexing unittests there. Shall see to that.. |
ee372c4
to
d383e7f
Compare
ee9caee
to
28983fd
Compare
Using this, a POST query made to _all indices (for example), in the following form: {
"query": {
"multi_match": {
"query": "2e2e8933451409eeda920ab6c35f7cde",
"fields": [
"_metadata.md5",
"_metadata.pbench_run_md5"
]
}
},
"from": 0,
"size": 2,
"fields": [
"_metadata.file-name",
"_metadata.nodename"
],
"sort": [],
"aggs": {}
} ..would result in : ...
"hits" : [
{
"_index" : "pbench.2015-10",
"_type" : "pbench-run",
"_id" : "2e2e8933451409eeda920ab6c35f7cde",
"_score" : 3.925263,
"fields" : {
"_metadata.file-name" : [ "/var/lib/pbench-agent/benchserver2_sample_pbench_run_2015-10-11.tar.xz" ]
}
},
{
"_index" : "pbench.sar-2015-10-11",
"_type" : "sar",
"_id" : "cd703c87c70ea9fe623ce748b4af1ca1",
"_score" : 2.7668054,
"fields" : {
"_metadata.nodename" : [ "benchserver2" ]
}
}
]
... |
@arcolife, can you rebase this commit? |
And then add unit tests? |
rebased. will add the unit tests. Although, is https://travis-ci.org/distributed-system-analysis/pbench/jobs/145559700#L907 this related to this PR? I've faced this before. |
@arcolife, I have seen that before, but I don't remember the root cause. We'll have to debug it. |
update: failure in pbench unit test [ref: https://github.com//pull/176#issuecomment-233359641 ] due to modification of index-pbench by this commit and consequently change in expected line numbers under pbench/bin/gold/test-*.txt (viz-a-viz test case output verification texts) ..and so the unittests:_verify_output() (code ref: https://github.com/distributed-system-analysis/pbench/blob/master/server/pbench/bin/unittests#L93 ) declares failed cases. |
test-9 (for this PR) fails at https://travis-ci.org/distributed-system-analysis/pbench/jobs/150102944#L784 |
@arcolife, I tried this out this morning, and this is due to your timezone. :( I think the sadf command needs to be invoked with TZ=UTC, I'll post a PR with a fix to your repo, so that you can pull that in adding it to this PR. |
Okay, your branch need to be rebased on top of upstream master before we can work this through. Can you do that so I can send you a PR? @arcolife |
Any further updates based on the comments made here so far, @arcolife? |
809f348
to
4dd7781
Compare
Usage:
Example usage (independent of pbench):
Total incompatibility when a required specific sadf script is not found:
Total incompatibility but sadf script found to deal with this:
Partial incompatibility, dealt with conversion:
Compatible versions:
|
37309ab
to
178a6cb
Compare
…pport Add unit tests for sar ingress under 'test-11'; Also: - fix existing unit tests for this branch; - update line no.s for gold test 7.{3..5}. Refer distributed-system-analysis#303 - update .gitignore: __pycache__ in any dir - cleanup sar-index code addition
d07261d
to
1946ae7
Compare
Add TODO task lists as comments in extract_sa.py ref: https://travis-ci.org/distributed-system-analysis/pbench/jobs/223371766#L876
Also, update TODO tasks in extract_sa.py
TODOs
Questions
|
Replaced by #645. |
w.r.t.: #227
This PR adds SAR data indexing capability to pbench. Details:
index-pbench
now calls a module -index-sar
._metadata.pbench_run_unique_id
) depicting path to sar file in results_metadata.pbench_run_md5
)