Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #2522 specjbb mdlog fix #2523

Merged
merged 5 commits into from Nov 10, 2021
Merged

Backport PR #2522 specjbb mdlog fix #2523

merged 5 commits into from Nov 10, 2021

Conversation

portante
Copy link
Member

@portante portante commented Nov 4, 2021 •
edited

This is a straight-forward back-port of part of PR #2522, the undefined mdlog variable, and the additional tests.

@portante
Backport pbench-specjbb2005's metadata.log fix
c010c61 
See PR distributed-system-analysis#2522.  This is a simple backport of the fix for the undefined
`mdlog` variable.
@portante portante added bug Agent specjbb2005 Related to the specjbb2005 benchmark script. labels Nov 4, 2021
@portante portante added this to the v0.69.10 milestone Nov 4, 2021
@portante portante self-assigned this Nov 4, 2021
@portante portante added this to In progress in Sprint 004 via automation Nov 4, 2021
@portante portante added this to In progress in v0.69.10 via automation Nov 4, 2021
@portante portante added this to In progress in Agent via automation Nov 4, 2021
dbutenhof
dbutenhof previously approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as for the main version, implicitly, but an additional comment which is really a metacomment on the main version. 😄

agent/bench-scripts/tests/pbench-specjbb2005/test-57.opts Show resolved Hide resolved
@webbnh
Copy link
Member

webbnh commented Nov 4, 2021

I'm going to hold off on reviewing this until #2522 is settled.

@portante
Copy link
Member Author

portante commented Nov 5, 2021

Now that PR #2522 is merge into main, can we consider this PR?

@portante portante force-pushed the backport-pr-2522-specjbb-mdlog branch from 4e856b5 to 55e51d6 Compare November 5, 2021 22:27
Agent automation moved this from In progress to Review in progress Nov 5, 2021
v0.69.10 automation moved this from In progress to Review in progress Nov 5, 2021
Sprint 004 automation moved this from In progress to Review in progress Nov 5, 2021
portante
portante commented Nov 5, 2021
View reviewed changes
Copy link
Member Author

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and ready for review.

dbutenhof
dbutenhof previously approved these changes Nov 8, 2021
View reviewed changes
agent/bench-scripts/tests/pbench-specjbb2005/test-56.pre Outdated Show resolved Hide resolved
@webbnh webbnh removed this from Review in progress in Sprint 004 Nov 8, 2021
@webbnh webbnh added this to In progress in Sprint 005 via automation Nov 8, 2021
Sprint 005 automation moved this from In progress to Review in progress Nov 8, 2021
dbutenhof
dbutenhof previously approved these changes Nov 8, 2021
View reviewed changes
webbnh
webbnh previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no single item here which would be worth holding this up for, but the sum of them makes it seem like another pass is in order.

agent/bench-scripts/test-bin/java Outdated Show resolved Hide resolved
agent/bench-scripts/test-bin/java Show resolved Hide resolved
agent/bench-scripts/tests/pbench-specjbb2005/test-56.post Show resolved Hide resolved
agent/bench-scripts/tests/pbench-specjbb2005/test-56.pre Show resolved Hide resolved
agent/bench-scripts/tests/pbench-specjbb2005/test-56.pre Show resolved Hide resolved
Agent automation moved this from Review in progress to Reviewer approved Nov 8, 2021
v0.69.10 automation moved this from Review in progress to Reviewer approved Nov 8, 2021
Sprint 005 automation moved this from Review in progress to Reviewer approved Nov 8, 2021
@webbnh
Copy link
Member

webbnh commented Nov 8, 2021

Also, it might be worth tweaking the PR description, as this only backports part of #2522 (as the other part doesn't apply).

@portante portante dismissed stale reviews from webbnh and dbutenhof via eb31822 November 8, 2021 21:11
Agent automation moved this from Reviewer approved to Review in progress Nov 8, 2021
v0.69.10 automation moved this from Reviewer approved to Review in progress Nov 8, 2021
v0.69.10 automation moved this from Reviewer approved to Review in progress Nov 8, 2021
Sprint 005 automation moved this from Reviewer approved to Review in progress Nov 8, 2021
Sprint 005 automation moved this from Reviewer approved to Review in progress Nov 8, 2021
Agent automation moved this from Review in progress to Reviewer approved Nov 9, 2021
v0.69.10 automation moved this from Review in progress to Reviewer approved Nov 9, 2021
Sprint 005 automation moved this from Review in progress to Reviewer approved Nov 9, 2021
@portante portante merged commit 7315f3d into distributed-system-analysis:b0.69 Nov 10, 2021
Agent automation moved this from Reviewer approved to Done Nov 10, 2021
v0.69.10 automation moved this from Reviewer approved to Done Nov 10, 2021
Sprint 005 automation moved this from Reviewer approved to Done Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

Assignees

@portante portante

Labels
Agent bug specjbb2005 Related to the specjbb2005 benchmark script.
Projects
No open projects
Agent
  
Done
Sprint 005
  
Done
v0.69.10
  
Done
Milestone
v0.69.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@portante @webbnh @dbutenhof