Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the pbench-perl-JSON-XS dependency #2749

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented Apr 12, 2022

All distros of interest now make perl-JSON-XS available either in
EPEL (for RHEL7) or in the CRB repo (for RHEL8 and above). The Fedoras
always had it available.

Delete obsolete targets in rpm.mk.

All distros of interest now make perl-JSON-XS available either in
EPEL (for RHEL7) or in the CRB repo (for RHEL8 and above). The Fedoras
always had it available.

Delete obsolete targets in rpm.mk.
@ndokos ndokos added Agent packaging Issues related to software packaging labels Apr 12, 2022
@ndokos ndokos added this to the v0.69.10 milestone Apr 12, 2022
@ndokos ndokos self-assigned this Apr 12, 2022
@ndokos ndokos added this to In progress in v0.69.10 via automation Apr 12, 2022
@ndokos ndokos added this to In progress in Agent via automation Apr 12, 2022
@ndokos ndokos requested a review from portante April 12, 2022 18:50
@portante portante changed the title Get rid of the pbench-perl-JSON-XS dependency Get rid of the pbench-perl-JSON-XS dependency Apr 12, 2022
Agent automation moved this from In progress to Reviewer approved Apr 12, 2022
v0.69.10 automation moved this from In progress to Reviewer approved Apr 12, 2022
@portante portante merged commit 9962422 into distributed-system-analysis:b0.69 Apr 12, 2022
Agent automation moved this from Reviewer approved to Done Apr 12, 2022
v0.69.10 automation moved this from Reviewer approved to Done Apr 12, 2022
@webbnh
Copy link
Member

webbnh commented Apr 12, 2022

This change was made for b0.69...is there a similar change due for main?

@ndokos
Copy link
Member Author

ndokos commented Apr 12, 2022

I didn't see a problem when testing with a 0.71 RPM but I must have missed RHEL7 which still uses pbench-perl-JSON-XS. So yes, there will be a similar change for main.

EDIT: the reason that I had not seen any problems with any of the RHELs was that I had built the 0.71 RPM I was using for testing in a branch where I had already made that change. But I was looking at main and wondering how the heck the RPM could possibly depend on perl-JSON-XS and not on pbench-perl-JSON-XS. PR coming.

ndokos added a commit to ndokos/pbench that referenced this pull request Apr 12, 2022
Similar to PR distributed-system-analysis#2749: `perl-JSON-XS` is provided by all the RHELs
through EPEL (for RHEL7) or the CRB repo (for RHEL8 and later).
webbnh pushed a commit that referenced this pull request Apr 12, 2022
Similar to PR #2749: `perl-JSON-XS` is provided by all the RHELs
through EPEL (for RHEL7) or the CRB repo (for RHEL8 and later).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent packaging Issues related to software packaging
Projects
No open projects
Agent
  
Done
v0.69.10
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants