Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix #3390

Merged
merged 1 commit into from Apr 19, 2023
Merged

Quick fix #3390

merged 1 commit into from Apr 19, 2023

Conversation

dbutenhof
Copy link
Member

keycloak-js 21.1.0 adds an explicit keycloak-masthead dependency that's broken. This went in early this morning, and has broken all users. To mitigate this, back off our package.json to depend on the latest previous verion, which is 21.0.2 to get our builds running again.

@dbutenhof
Quick fix
6aafb7d 
`keycloak-js` 21.1.0 adds an explicit `keycloak-masthead` dependency that's
broken. This went in early this morning, and has broken all users. To mitigate
this, back off our `package.json` to depend on the latest previous verion,
which is 21.0.2 to get our builds running again.
@dbutenhof dbutenhof added the Dashboard Of and relating to the Dashboard GUI label Apr 19, 2023
@dbutenhof dbutenhof self-assigned this Apr 19, 2023
webbnh
webbnh approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. How are we going to know (and remember) to back this out again?

@dbutenhof dbutenhof merged commit c74bd4f into distributed-system-analysis:main Apr 19, 2023
3 of 4 checks passed
@dbutenhof
Copy link
Member Author

Ugh. How are we going to know (and remember) to back this out again?

Yeah; it's an issue, but there's already a keycloak-js PR to fix it, so with luck we can repair this later today.

Apparently what happened was adding explicit versions to all dependencies; and keycloak-masthead is an internal package that's not actually published separately. Their CI must only use a contaminated node_modules cache; but the version makes npm try to fetch it, which can't ever work because it's not published. Yikes.

@webbnh
Copy link
Member

webbnh commented Apr 19, 2023

See keycloak/keycloak Issues #19800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portante portante portante approved these changes

@webbnh webbnh webbnh approved these changes

@MVarshini MVarshini Awaiting requested review from MVarshini

@npalaska npalaska Awaiting requested review from npalaska

@vishalvvr vishalvvr Awaiting requested review from vishalvvr

@riya-17 riya-17 Awaiting requested review from riya-17

@siddardh-ra siddardh-ra Awaiting requested review from siddardh-ra

Assignees

@dbutenhof dbutenhof

Labels
Dashboard Of and relating to the Dashboard GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbutenhof @webbnh @portante