Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't report API Keys as errors #3438

Merged
merged 1 commit into from May 30, 2023
Merged

Don't report API Keys as errors #3438

merged 1 commit into from May 30, 2023

Conversation

dbutenhof
Copy link
Member

PBENCH-1168

Our API Key structure causes the primary OIDC key validation to fail with a ValueError exception. This isn't caught by the handler, and propagates to the caller's except Exception where it's reported as an error with traceback, which we don't want for a routine key validation.

This just adds ValueError to the catch to avoid the annoying log message.

@dbutenhof
Don't report API Keys as errors
346a060 
PBENCH-1168

Our API Key structure causes the primary OIDC key validation to fail with a
`ValueError` exception. This isn't caught by the handler, and propagates to
the caller's `except Exception` where it's reported as an error with
traceback, which we don't want for a routine key validation.

This just adds `ValueError` to the catch to avoid the annoying log message.
@dbutenhof dbutenhof added bug Server API Of and relating to application programming interfaces to services and functions labels May 26, 2023
@dbutenhof dbutenhof self-assigned this May 26, 2023
@dbutenhof
Copy link
Member Author

Destroyed by another dashboard build issue:

/home/jenkins/pbench/dashboard/src/App.js
0:0 error Parsing error: [BABEL] /home/jenkins/pbench/dashboard/src/App.js: Cannot find module '@babel/plugin-proposal-private-property-in-object'

(repeated for apparently every one of our Javascript files)

I'm going to just sit on this and hope that (once again) it gets fixed without wasting our triage time ... but one never knows ...

webbnh
webbnh approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks fine.

Regarding the ESLint issue, @babel/core was updated an hour ago....

@dbutenhof
Copy link
Member Author

Regarding the ESLint issue, @babel/core was updated an hour ago....

Of course it was. Does nobody do QA?

@dbutenhof
Copy link
Member Author

Regarding the ESLint issue, @babel/core was updated an hour ago....

Of course it was. Does nobody do QA?

Seems to be fixed now.

@dbutenhof dbutenhof closed this May 26, 2023
@dbutenhof dbutenhof reopened this May 26, 2023
@dbutenhof dbutenhof merged commit 6d766a7 into distributed-system-analysis:main May 30, 2023
6 checks passed
@dbutenhof dbutenhof deleted the keyerr branch May 30, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@npalaska npalaska npalaska approved these changes

@riya-17 riya-17 Awaiting requested review from riya-17

@siddardh-ra siddardh-ra Awaiting requested review from siddardh-ra

Assignees

@dbutenhof dbutenhof

Labels
API Of and relating to application programming interfaces to services and functions bug Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbutenhof @webbnh @npalaska