Increase Nginx limits for internal responses #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
added
Server
Code Infrastructure
Containerization
dbutenhof
requested changes
Jul 25, 2023
dbutenhof
reviewed
Jul 25, 2023
webbnh
force-pushed
the
nginx_limits_for_internals
branch
from
fd2c3ba
to
493d2f0
Compare
dbutenhof
approved these changes
Jul 25, 2023
webbnh
added a commit
to webbnh/pbench
that referenced
this pull request
Jul 27, 2023
webbnh
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent "Ops Review" revealed a mysterious behavior around the "inner" Nginx proxy: whenever we had a request timeout, we immediately had a second failure which returned a
413response to the client. We initially thought that this was a configuration problem in the "outer" proxy, but that proved to be unfounded. Then I stumbled onto this explanation: because theclient_max_body_sizeis increased only for the Pbench Server API routes, when the request times out and is redirected to the internal50X.htmlpage, the maximum request size changes back to the default, and the redirected request fails with a413instead of the appropriate504.This PR adds
client_max_body_sizeto the two internal routes, to allow them to function properly in the face of large request sizes. (We don't make theclient_max_body_sizedefinition global, because there is no reason to tolerate large request sizes for the other routes.)