Fix server tests on b0.73 branch #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1256 The b0.73 branch code branched after Quisby `uperf` visualization support, but the `pquisby` 0.0.17 package adds `fio`, breaking a few tests that expect only `uperf`. We don't intend to support the server on the b0.73 branch, so it seems most appropriate to lock the `pquisby` package to 0.0.12 which exposes only `uperf` and matches the tests on that branch.
ndokos
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1256
The b0.73 branch code branched after Quisby
uperfvisualization support, but thepquisby0.0.17 package addsfio, breaking a few tests that expect onlyuperf. We don't intend to support the server on the b0.73 branch, so it seems most appropriate to lock thepquisbypackage to 0.0.12 which exposes onlyuperfand matches the tests on that branch.