move interval to config file from gc/expire work #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nioshield
requested review from
nightmeng,
arthurkiller,
YIDWang and
gengxinMT
arthurkiller
requested changes
Feb 1, 2019
arthurkiller
approved these changes
Feb 1, 2019
|
LGTM :) |
YIDWang
requested changes
Feb 2, 2019
nioshield
force-pushed
the
feature/gc-interval-conf
branch
from
08b621b
to
888f535
Compare
|
@YIDWang Please take another look, your requests have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the gc/expire related configuration to the titan.toml configuration file