-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple the metrics endpoint from debug #4085
Comments
No, the docs are suggesting to lock it down i.e. do not leave it open to public -- you know people on the internet can be kinda mean. That doesnt mean that you can't keep this API endpoint private and scrape prometheus metrics as you do in our other applications |
Initially I misunderstood that the debug endpoint has to be disabled in production environments. That's why I created distribution#4084 and distribution#4085. But it turns out that the docs want to state the the debug endpoint should not be exposed publicly to the internet.
Initially I misunderstood that the debug endpoint has to be disabled in production environments. That's why I created distribution#4084 and distribution#4085. But it turns out that the docs want to state the the debug endpoint should not be exposed publicly to the internet.
Thanks! It seems that we misunderstood the docs. I created #4089 to clarify further the docs. |
Initially I misunderstood that the debug endpoint has to be disabled in production environments. That's why I created distribution#4084 and distribution#4085. But it turns out that the docs want to state the the debug endpoint should not be exposed publicly to the internet. Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Similar to #4084.
There is a
/debug/metrics
endpoint that gets available when thedebug.addr
is specified anddebug.prometheus.enabled
is enabled (ref https://docs.docker.com/registry/configuration/#prometheus).Note that the docs suggest not enabling this in production env:
Having in mind the above, how is it supposed to collect metrics in production environments? The docs state that the debug feature has to be disabled in production environments. On the other side, it is a cloud native and observability principle to collect metrics in all environments.
I rather thing that the metrics endpoint has to be decoupled from debug and it needs to have its own configurable port and its own configuration option whether it is enabled or not.
The text was updated successfully, but these errors were encountered: