Add features to the s3 driver #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyKostov
changed the title
The secure flag will be true by default and will change the s3 endpoint of the region to http instead of https when selected as false. The main benefits of running with secure being false is that it apparently has a roughly 33% performance boost (even on pure data transfer, not only connection setup which is what I would have expected).
AndreyKostov
force-pushed
the
ng-add-s3driver-features
branch
from
9e4c197
to
416808b
Compare
v4auth will default to true and if the frankfurt (eu-central-1) region is selected with v4auth set to false explicitly, the driver will error out upon initialization.
AndreyKostov
force-pushed
the
ng-add-s3driver-features
branch
from
416808b
to
a0ef0d6
Compare
AndreyKostov
force-pushed
the
ng-add-s3driver-features
branch
from
e12d727
to
887e22d
Compare
|
Thanks a lot @AndreyKostov ! |
| shouldEncrypt, err := strconv.ParseBool(encrypt) | ||
| if err != nil { | ||
| return nil, err | ||
| encryptBool := true |
There was a problem hiding this comment.
encrypt should default to false like the semantic defined in the README. Also, you should remove this from the list of environment variables required to run the tests.
AndreyKostov
force-pushed
the
ng-add-s3driver-features
branch
2 times, most recently
from
8ed22bb
to
d63f59a
Compare
|
@AndreyKostov github seems to be working correctly again, so try re-triggering the circle build. |
AndreyKostov
force-pushed
the
ng-add-s3driver-features
branch
from
d63f59a
to
bc9509d
Compare
|
LGTM |
|
LGTM! |
stevvooe
added a commit
that referenced
this pull request
Jan 12, 2015
Add features to the s3 driver
This was referenced Jan 13, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet, as this is blocked on the v4 auth option.