Better error message for BuildManifestURL if not tagged or digested #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
reviewed
Mar 2, 2017
registry/api/v2/urls.go
Outdated
| @@ -175,6 +176,8 @@ func (ub *URLBuilder) BuildManifestURL(ref reference.Named) (string, error) { | |||
| tagOrDigest = v.Tag() | |||
| case reference.Digested: | |||
| tagOrDigest = v.Digest().String() | |||
| default: | |||
| return "", fmt.Errorf("Named Reference must have tag or digest") | |||
There was a problem hiding this comment.
Error messages should generally start with a lowercase character.
I'd suggest reference must have a tag or digest.
Since there's no default case, if there's not a tag or digest you get back a confusing error from the router about it not matching the expected pattern. Also redoing the tests for URLs a bit so that they can handle checking for failures. Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com>
clnperez
force-pushed
the
manifest-url-err
branch
from
ed25f5a
to
0810eba
Compare
|
@aaronlehmann I changed that err msg, thanks! |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's no default case, if there's not a tag or digest you get
back a confusing error from the router about it not matching the
expected pattern.
Also redoing the tests for URLs a bit so that they can handle checking
for failures.
Signed-off-by: Christy Perez christy@linux.vnet.ibm.com