Breakup common package #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the efforts to break up the common package before disaster strikes, a new collections package has been created. More may belong there but for now, it only includes an implementation of StringSet. Signed-off-by: Stephen J Day <stephen.day@docker.com>
In preparation for removing the common package, the tarsum utilities are being moved to the more relevant digest package. This functionality will probably go away in the future, but it's maintained here for the time being. Signed-off-by: Stephen J Day <stephen.day@docker.com>
Because the repository name definitions are part of the v2 specification, they have been moved out of the common package. This is part of the effort to break up the common package into more sensible components. Signed-off-by: Stephen J Day <stephen.day@docker.com>
Since the common package no longer exists, the testutil package is being moved up to the root. Ideally, we don't have large omnibus packages, like testutil, but we can fix that in another refactoring round. Signed-off-by: Stephen J Day <stephen.day@docker.com>
4 tasks
|
LGTM |
|
Are we creating a |
|
@icecrime Yes. I'm not tied to the concept of a Let me know what you prefer. |
|
You know better, but if it's only used in |
The exported StringSet type is not necessary for the current use case of validating issues and audiences. The exported fields on VerifyOptions have been changed to require string slices. The collections package has been removed and the StringSet has been moved to the token package, where it is used. Signed-off-by: Stephen J Day <stephen.day@docker.com>
|
@icecrime Fixed. ;) |
|
LGTM |
openshift-publish-robot
referenced
this pull request
in openshift/docker-distribution
May 21, 2018
bump(*) Image-registry-commit: 8f7ef225cf4dada45f2e72ea729c50bb62324539
openshift-publish-robot
referenced
this pull request
in openshift/docker-distribution
Jun 18, 2018
bump(*) Image-registry-commit: 8f7ef225cf4dada45f2e72ea729c50bb62324539
dmage
pushed a commit
to dmage/distribution
that referenced
this pull request
Feb 23, 2022
UPSTREAM: docker/distribution: 3057: allow for optional S3 debugging -- closes issue distribution#2043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catchall common packages are generally an indication of bad organization, so we are getting rid of it while it is small. Mostly, types were moved to other, more relevant packages or a new package was created. Please see the individual commits for details.
This addresses items discussed in #6.