Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aws sdk: permit to work with s3 compliant storage with sigv4 #2563

Closed

Conversation

hightoxicity
Copy link

AWS GO SDK update to be able to store images on openio-sds, swift3 (s3 compliants) storages.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "feat-update-aws-sdk-go" git@github.com:hightoxicity/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@stevvooe
Copy link
Collaborator

stevvooe commented Apr 6, 2018

@hightoxicity Make sure to format your commit message correctly. It looks like the subject line and sign off have been switched around some how.

@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #2563 into master will decrease coverage by 9.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2563      +/-   ##
=========================================
- Coverage   60.87%   51.2%   -9.67%     
=========================================
  Files         129     129              
  Lines       11876   11876              
=========================================
- Hits         7229    6081    -1148     
- Misses       3744    5032    +1288     
+ Partials      903     763     -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83389a1...e7d258d. Read the comment docs.

Signed-off-by: Tony Fouchard <djnos14@hotmail.com>
@dmp42
Copy link
Contributor

dmp42 commented Aug 23, 2018

Superseded by #2678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants