New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate the platform information when calling the References() method of manifest list #2911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a6b6cd5
to
948d550
Compare
Got error in travis:
What does it mean? I didn't modify any code under vendor directory. |
@ywk253100 Can you execute the following steps? i) Rebase |
948d550
to
c1d8fd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2911 +/- ##
==========================================
- Coverage 60.59% 60.57% -0.03%
==========================================
Files 102 102
Lines 8025 8031 +6
==========================================
+ Hits 4863 4865 +2
- Misses 2512 2515 +3
- Partials 650 651 +1
Continue to review full report at Codecov.
|
@tariq1890 Thanks. |
@ywk253100 can you please rebase? |
…d of manifest list Populate the platform information when calling the References() method of manifest list Signed-off-by: Wenkai Yin <yinw@vmware.com>
c1d8fd8
to
1a059fe
Compare
@milosgajdos rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Populate the platform information when calling the References() method of manifest list
Signed-off-by: Wenkai Yin yinw@vmware.com