Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the platform information when calling the References() method of manifest list #2911

Merged
merged 1 commit into from Mar 2, 2021

Conversation

ywk253100
Copy link
Contributor

Populate the platform information when calling the References() method of manifest list

Signed-off-by: Wenkai Yin yinw@vmware.com

Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywk253100
Copy link
Contributor Author

Got error in travis:

$ script/validate/vendor
2019/05/17 07:33:35 Collecting initial packages
2019/05/17 07:33:35 Download dependencies
2019/05/17 07:33:36 Starting whole vndr cycle because no package specified
2019/05/17 07:34:29 Dependencies downloaded. Download time: 52.852440902s
2019/05/17 07:34:29 Collecting all dependencies
2019/05/17 07:34:29 WARNING: dependency is not vendored: golang.org/x/sys/unix
2019/05/17 07:34:31 Clean vendor dir from unused packages
2019/05/17 07:34:31 Success
2019/05/17 07:34:31 Running time: 56.576013268s
These files were modified:
?? vendor/github.com/aws/aws-sdk-go/go.mod
?? vendor/gopkg.in/yaml.v2/go.mod
The command "script/validate/vendor" exited with 1.

What does it mean? I didn't modify any code under vendor directory.

@tariq1890
Copy link
Contributor

@ywk253100 Can you execute the following steps?

i) Rebase
ii) Run GO111MODULE=on go mod tidy
iii) Run GO111MODULE=on go mod vendor
iv) Commit and push all the changed files.

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #2911 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
- Coverage   60.59%   60.57%   -0.03%     
==========================================
  Files         102      102              
  Lines        8025     8031       +6     
==========================================
+ Hits         4863     4865       +2     
- Misses       2512     2515       +3     
- Partials      650      651       +1
Flag Coverage Δ
#linux 60.57% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
manifest/manifestlist/manifestlist.go 73.41% <100%> (+2.18%) ⬆️
registry/handlers/app.go 48.16% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90dfea7...c1d8fd8. Read the comment docs.

@ywk253100
Copy link
Contributor Author

@tariq1890 Thanks.

Base automatically changed from master to main January 27, 2021 15:51
@milosgajdos
Copy link
Member

@ywk253100 can you please rebase?

…d of manifest list

Populate the platform information when calling the References() method of manifest list

Signed-off-by: Wenkai Yin <yinw@vmware.com>
@ywk253100
Copy link
Contributor Author

@milosgajdos rebased

Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos milosgajdos merged commit 3eee56e into distribution:main Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants