Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append the written bytes to the blob writer's size #2920

Merged
merged 1 commit into from Jun 20, 2019
Merged

Append the written bytes to the blob writer's size #2920

merged 1 commit into from Jun 20, 2019

Conversation

dmathieu
Copy link
Contributor

@dmathieu dmathieu commented May 9, 2019

Any byte written should append to the size. Otherwise, the full Size is always zero.

append the written bytes to the blob writer's size
0e2d080 
Any byte written should append to the size. Otherwise, the full Size is
always zero.

Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
@dmathieu dmathieu mentioned this pull request May 10, 2019
Closed
caervs
caervs approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense to me.

@caervs caervs requested a review from manishtomar May 15, 2019 21:18
@caervs caervs merged commit 6c329e5 into distribution:master Jun 20, 2019
@dmathieu dmathieu deleted the blob_writer_offset branch June 20, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caervs caervs caervs approved these changes

@manishtomar manishtomar Awaiting requested review from manishtomar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmathieu @caervs