Extract blob upload resume into its own method #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @caervs |
caervs
approved these changes
May 24, 2019
I've found this logic being in a single method to be quite hard to get. I believe extracting it makes it easier to read, as we can then more easily see what the main method does and possibly ignore the intricacies of `ResumeBlobUpload`. Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
==========================================
+ Coverage 60.45% 60.47% +0.01%
==========================================
Files 102 102
Lines 8002 8006 +4
==========================================
+ Hits 4838 4842 +4
Misses 2515 2515
Partials 649 649
Continue to review full report at Codecov.
|
|
@dmathieu Thanks for resolving merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this logic being in a single method to be quite hard to get.
I believe extracting it makes it easier to read, as we can then more easily see what the main method does and possibly ignore the intricacies of
ResumeBlobUpload.