Support ECS TaskRole in S3 storage driver #2973
Conversation
|
Hi @abulford and thanks for the fix which would be a big help to me. The build is failing on the execution |
|
Ok @abulford looks like the failing vendor modules check is nothing to do with your change but related to some kind of inconsistency in |
|
@btisdall sorry for missing your comments before - yes, I seem to remember when I submitted this I looked around and saw this test was failing elsewhere as well so assumed it was a known issue and hopefully wouldn't affect the review. I would have investigated further but was rushing something out at the time. Thanks for looking into this! |
|
Is there anything I can do to move this forward? We have a project that's suffering from this exact problem and it's pretty much the last piece. |
|
How is this still waiting? This is a critical patch... lets get this in! |
|
LGTM It looks like the build is failing on the vendor changes. Are there any tests? |
|
I've come back to a project that was relying on this and could do with it being merged so I can revert to the official release rather than my fork. Is there anything I can do to move this along? Or is this just awaiting the review from @manishtomar? |
|
Would love to see this merged and released. We're using our own generic HTTP credentials provider throughout our environment and the registry is the only outlier we have. |
|
Could you rebase this with latest master to fix the CI? |
Instead of constructing the list of credential providers manually, if we use the default list we can take advantage of the AWS SDK checking the environment and returning either the EC2RoleProvider or the generic HTTP credentials provider, configured to use the ECS credentials endpoint. Also, use the `defaults.Config()` function instead of `aws.NewConfig()`, as this results in an initialised HTTP client which prevents a fatal error when retrieving credentials from the ECS credentials endpoint. Fixes distribution#2960 Signed-off-by: Andrew Bulford <andrew.bulford@redmatter.com>
abulford
force-pushed
the
support-ecs-instance-profile-in-s3-driver
branch
from
920076b
to
9690d84
Compare
|
@manishtomar rebase done, CI is passing now! :) |
|
So, what's remaining to merge this? |
|
This needs to be tested in AWS before merging. I was hoping to do that but have been busy. |
|
@manishtomar Tested this works in Fargate and locally with env variables. |
|
Thanks @manishtomar! |
Reopen PR #2973 (Support ECS TaskRole in S3 storage driver).
|
Any chance of getting a new release that encompasses this? |
Instead of constructing the list of credential providers manually, if we use the default list we can take advantage of the AWS SDK checking the environment and returning either the EC2RoleProvider or the generic HTTP credentials provider, configured to use the ECS credentials endpoint.
Also, use the
defaults.Config()function instead ofaws.NewConfig(), as this results in an initialised HTTP client which prevents a fatal error when retrieving credentials from the ECS credentials endpoint.Fixes #2960
Signed-off-by: Andrew Bulford andrew.bulford@redmatter.com