Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest version of alpine when building the Docker container #2991

Merged
merged 1 commit into from Oct 24, 2019
Merged

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Aug 29, 2019

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:ad-m/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Adam Dobrawy <naczelnik@jawnosc.tk>
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #2991 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
- Coverage   60.69%   60.64%   -0.05%     
==========================================
  Files         102      102              
  Lines        8044     8044              
==========================================
- Hits         4882     4878       -4     
- Misses       2511     2514       +3     
- Partials      651      652       +1
Flag Coverage Δ
#linux 60.64% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
registry/handlers/app.go 48.16% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb7fff...a994bb8. Read the comment docs.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan PTAL

@ad-m
Copy link
Contributor Author

ad-m commented Sep 5, 2019

Can I help you in some way?

@thaJeztah
Copy link
Member

let me try getting a maintainer to review 🤗

Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ad-m
Copy link
Contributor Author

ad-m commented Oct 24, 2019

Is there anything what I can do to help merge that PR?

@dmcgowan dmcgowan merged commit dee21c0 into distribution:master Oct 24, 2019
@ad-m ad-m deleted the patch-1 branch October 25, 2019 00:40
@ad-m
Copy link
Contributor Author

ad-m commented Oct 25, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants