Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Azure Storage Driver with Latest SDK #3029

Closed
wants to merge 3 commits into from
Closed

Updated Azure Storage Driver with Latest SDK #3029

wants to merge 3 commits into from

Conversation

shizhMSFT
Copy link

Updated registry/storage/driver/azure/azure.go with the latested SDK (Azure/azure-storage-blob-go).

Resolves #3028

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "new_sdk" git@github.com:shizhMSFT/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354171776
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ae2e973). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3029   +/-   ##
=========================================
  Coverage          ?   60.73%           
=========================================
  Files             ?      102           
  Lines             ?     8073           
  Branches          ?        0           
=========================================
  Hits              ?     4903           
  Misses            ?     2518           
  Partials          ?      652
Flag Coverage Δ
#linux 60.73% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2e973...3d9d4b5. Read the comment docs.

Base automatically changed from master to main January 27, 2021 15:51
@flavianmissi
Copy link
Contributor

@shizhMSFT it looks like they're sticking with the azure-sdk-for-go pkg, see the azure-storage-blob-go repo readme:

If you would like to access our latest Go SDK, please refer to the new preview azblob package here. If you would like more information on Azure's burgeoning effort to coordinate the development of the SDKs across services, of which this change is a part, please refer to this article.

@milosgajdos
Copy link
Member

There is a PR that updates Azure integration: #3839

@shizhMSFT
Copy link
Author

Closing this PR as it is outdated and is succeeded by #3839

@shizhMSFT shizhMSFT closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Azure Storage Driver
5 participants