Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for optional S3 debugging -- closes issue #2043 #3057

Closed
wants to merge 2 commits into from

Conversation

vleurgat
Copy link
Contributor

recent S3 storage issues made it very useful to be able to enable S3 API debug logging; contributing those simple enhancements back to the project; closes issue #2043 from 2016

Signed-off-by: Simon Compston <compston@gmail.com>
Signed-off-by: Simon Compston <compston@gmail.com>
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #3057 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3057   +/-   ##
=======================================
  Coverage   60.73%   60.73%           
=======================================
  Files         102      102           
  Lines        8073     8073           
=======================================
  Hits         4903     4903           
  Misses       2518     2518           
  Partials      652      652
Flag Coverage Δ
#linux 60.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee21c0...f1861f3. Read the comment docs.

@glance-
Copy link

glance- commented Dec 16, 2019

This PR is extremly usefull when debugging issues with S3 backend against radosgw, so I would love to see this merged.

@glance-
Copy link

glance- commented Dec 16, 2019

The only thing I'd suggest is that you squash those two commits together. They make no sense being two different commits, and as the tests fail with only the first commit will cause problems when running a git bisect.

@glance- glance- mentioned this pull request Dec 16, 2019
Base automatically changed from master to main January 27, 2021 15:51
@milosgajdos
Copy link
Member

@vleurgat do you wanna rebase?

flavianmissi added a commit to flavianmissi/docker-distribution that referenced this pull request Sep 27, 2023
based on the work from
distribution#3057.

Co-authored-by: Simon Compston <compston@gmail.com>
Signed-off-by: Flavian Missi <fmissi@redhat.com>
flavianmissi added a commit to flavianmissi/docker-distribution that referenced this pull request Sep 27, 2023
based on the work from
distribution#3057.

Co-authored-by: Simon Compston <compston@gmail.com>
Signed-off-by: Flavian Missi <fmissi@redhat.com>
@flavianmissi
Copy link
Contributor

flavianmissi commented Sep 27, 2023

Hi folks,
Since there's been no movement on the author's part I took the liberty to recreate this PR (with a few changes): #4076

flavianmissi added a commit to flavianmissi/docker-distribution that referenced this pull request Oct 2, 2023
based on the work from
distribution#3057.

Co-authored-by: Simon Compston <compston@gmail.com>
Signed-off-by: Flavian Missi <fmissi@redhat.com>
@Jamstah
Copy link
Collaborator

Jamstah commented Oct 17, 2023

Closed in #4076

@Jamstah Jamstah closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants