-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for optional S3 debugging -- closes issue #2043 #3057
Conversation
Signed-off-by: Simon Compston <compston@gmail.com>
Signed-off-by: Simon Compston <compston@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
=======================================
Coverage 60.73% 60.73%
=======================================
Files 102 102
Lines 8073 8073
=======================================
Hits 4903 4903
Misses 2518 2518
Partials 652 652
Continue to review full report at Codecov.
|
This PR is extremly usefull when debugging issues with S3 backend against radosgw, so I would love to see this merged. |
The only thing I'd suggest is that you squash those two commits together. They make no sense being two different commits, and as the tests fail with only the first commit will cause problems when running a git bisect. |
@vleurgat do you wanna rebase? |
based on the work from distribution#3057. Co-authored-by: Simon Compston <compston@gmail.com> Signed-off-by: Flavian Missi <fmissi@redhat.com>
based on the work from distribution#3057. Co-authored-by: Simon Compston <compston@gmail.com> Signed-off-by: Flavian Missi <fmissi@redhat.com>
Hi folks, |
based on the work from distribution#3057. Co-authored-by: Simon Compston <compston@gmail.com> Signed-off-by: Flavian Missi <fmissi@redhat.com>
Closed in #4076 |
recent S3 storage issues made it very useful to be able to enable S3 API debug logging; contributing those simple enhancements back to the project; closes issue #2043 from 2016