Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update governance and maintainers #3110

Merged
merged 1 commit into from Mar 4, 2020

Conversation

dmcgowan
Copy link
Collaborator

@dmcgowan dmcgowan commented Mar 4, 2020

Update format of governance and bring in language from containerd.
Update maintainers to reflect active maintainers.
Maintainer changes: Manish from reviewer to maintainer, +Sebastian as reviewer, -Olivier as maintainer

2 maintainer LGTM required + new maintainer + new reviewer

Copy link
Collaborator

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@distribution distribution deleted a comment from codecov bot Mar 4, 2020
Copy link
Contributor

@manishtomar manishtomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,3 +0,0 @@
## Docker Distribution Community Code of Conduct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GitHub uses this file in their "https://github.com/docker/distribution/community" rating, but it seems to have trouble detecting the file already, so not sure it's super important.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it into the .github directory. Since it is mentioned in the governance file, don't need it in the root. Also in a separate PR I think we should fill in the content of the code of conduct rather than just linking. While the CNCF CoC is a good template, it doesn't really apply to non-CNCF projects since the point of escalation is specifically for those projects.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one note

Update format of governance and bring in language from containerd.
Update maintainers to reflect active maintainers.

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #3110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3110   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files         104      104           
  Lines        8434     8434           
=======================================
  Hits         4949     4949           
  Misses       2823     2823           
  Partials      662      662
Flag Coverage Δ
#linux 58.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b972e5...1e25ece. Read the comment docs.

@dmcgowan dmcgowan merged commit 3b4d1e3 into distribution:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants