New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update governance and maintainers #3110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code-of-conduct.md
Outdated
@@ -1,3 +0,0 @@ | |||
## Docker Distribution Community Code of Conduct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think GitHub uses this file in their "https://github.com/docker/distribution/community" rating, but it seems to have trouble detecting the file already, so not sure it's super important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it into the .github
directory. Since it is mentioned in the governance file, don't need it in the root. Also in a separate PR I think we should fill in the content of the code of conduct rather than just linking. While the CNCF CoC is a good template, it doesn't really apply to non-CNCF projects since the point of escalation is specifically for those projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one note
Update format of governance and bring in language from containerd. Update maintainers to reflect active maintainers. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
cf32830
to
1e25ece
Compare
Codecov Report
@@ Coverage Diff @@
## master #3110 +/- ##
=======================================
Coverage 58.67% 58.67%
=======================================
Files 104 104
Lines 8434 8434
=======================================
Hits 4949 4949
Misses 2823 2823
Partials 662 662
Continue to review full report at Codecov.
|
Update format of governance and bring in language from containerd.
Update maintainers to reflect active maintainers.
Maintainer changes: Manish from reviewer to maintainer, +Sebastian as reviewer, -Olivier as maintainer
2 maintainer LGTM required + new maintainer + new reviewer