manifests: Return UNSUPPORTED when deleting manifests by tag #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes the conformance error seen here: https://oci-conformance.s3.amazonaws.com/distribution-spec/distribution/content-management/report.html |
The OCI distribution spec allows implementations to support deleting manifests by tag, but also permits returning the `UNSUPPORTED` error code for such requests. docker/distribution has never supported deleting manifests by tag, but previously returned `DIGEST_INVALID`. The `Tag` and `Digest` fields of the `manifestHandler` are already correctly populated based on which kind of reference was given in the request URL. Return `UNSUPPORTED` if the `Tag` field is populated. Signed-off-by: Adam Wolfe Gordon <awg@digitalocean.com>
adamwg
force-pushed
the
manifest-delete-by-tag
branch
from
d19edab
to
95f1eea
Compare
waynr
approved these changes
Aug 7, 2020
milosgajdos
added
the
conformance
milosgajdos
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI distribution spec allows implementations to support deleting manifests by tag, but also permits returning the
UNSUPPORTEDerror code for such requests. docker/distribution has never supported deleting manifests by tag, but previously returnedDIGEST_INVALID.The
TagandDigestfields of themanifestHandlerare already correctly populated based on which kind of reference was given in the request URL. ReturnUNSUPPORTEDif theTagfield is populated.Signed-off-by: Adam Wolfe Gordon awg@digitalocean.com