Make redirect middleware can use path #3206
Conversation
takmatsu
force-pushed
the
suppurt-path-in-middleware
branch
from
edf7535
to
b9f76e4
Compare
takmatsu
force-pushed
the
suppurt-path-in-middleware
branch
from
a721e29
to
537fb61
Compare
|
Any reason this hasn't been merged yet, we'd like to use this feature |
|
@milosgajdos 👋 I was looking into this very same feature and got hit by the same problem. Apparently, the path is not respected :( Is there anything that can be done here to get this PR merged, or should people willing on having this same middleware feature use this as an extension point on docker distribution but write their own middleware? Thank you very much!!! |
|
I'll close and reopen this PR so it re-kicks the CI. |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 58.22% 55.81% -2.42%
==========================================
Files 105 108 +3
Lines 8362 10969 +2607
==========================================
+ Hits 4869 6122 +1253
- Misses 2836 4161 +1325
- Partials 657 686 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@takmatsu can you also please squash the commits |
Signed-off-by: MATSUMOTO TAKEAKI <takeaki.matsumoto@linecorp.com>
Signed-off-by: MATSUMOTO TAKEAKI <takeaki.matsumoto@linecorp.com>
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
milosgajdos
force-pushed
the
suppurt-path-in-middleware
branch
from
7031ee7
to
316e1c6
Compare
|
@milosgajdos thank you very very much for pushing this :)) |
This patch enable us to use path in redirect middleware.
Currently, redirect middleware respects only scheme and host.
But actually our S3-Compatible storage needs this features for redirect to object storage endpoint.
and I believe this should be useful also for other users.
Related: #3022