Add GH action CI workflows to replace travis CI. #3312
Conversation
milosgajdos
changed the title
|
hey @milosgajdos , thanks to @crazy-max , he raised a PR to add a dummy GHA (#3314) which enabled GH actions on this repo. |
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
There was a problem hiding this comment.
@milosgajdos We can talk about it in the community Slack if you want
| - name: Validate DCO | ||
| env: | ||
| DCO_VERBOSITY: "-q" | ||
| GIT_CHECK_EXCLUDE: "./vendor:./script/validate/template" | ||
| run: git-validation "${DCO_VERBOSITY}" -run DCO,short-subject,dangling-whitespace |
There was a problem hiding this comment.
DCO can be handled directly through the DCO Probot App like we currently do on moby or buildx:
Just need to enable it for this repo.
There was a problem hiding this comment.
Sounds good, as a first step I wanted to "copy" the existing travis build process and iterate on it once this repo has something working. The sooner this repo gets off travis the better.
| - name: Check go.mod matches the source code in the module | ||
| run: go mod tidy | ||
|
|
||
| - name: Vendor go modules | ||
| run: go mod vendor | ||
|
|
||
| - name: Checking for unused packages in vendor | ||
| run: | | ||
| git diff --exit-code -- go.sum go.mod vendor/ | ||
| untracked=$(git ls-files --others vendor | wc -l | awk '{ print $1 }') | ||
| [[ "${untracked}" == "0" ]] |
There was a problem hiding this comment.
I think it would be more efficient to handle vendors validation (and update) through a dedicated Dockerfile to be able to reproduce locally. I've started to work on it but didn't saw your PR since yesterday ^^
There was a problem hiding this comment.
As reference, you can find more info about the migration plan of buildx and buildkit in docker/buildx#451.
There was a problem hiding this comment.
Gotcha. Yeah, that looks interesting. Need to look into that, thanks.
Btw, if you are keen on getting actions working I'm happy to close this PR. I just wanted to get the ball rolling quickly on this. I'm not hung on getting this into master. As long as it's done by anyone I'm happy.
There was a problem hiding this comment.
@milosgajdos Yeah sure I can work on it if you don't mind!
There was a problem hiding this comment.
Not at all! Thanks. I'm just glad someone else other than me cares about this now :-)
|
Closing this and leaving it in dedicated and capable hands of @crazy-max |
This is a WIP for replacing travis CI with GH actions.
Signed-off-by: Milos Gajdos milosgajdos83@gmail.com