Add CodeQL Security Scanning #3341
Conversation
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
|
@chrispat PTAL I see one failure ("base branch not found"); is this an issue in the configuration that's added in this PR, or an issue on GitHub's side?
|
|
I think this is because we don't have code scanning data for |
|
Ah, gotcha, makes sense. |
| # The branches below must be a subset of the branches above | ||
| branches: [ main ] | ||
| schedule: | ||
| - cron: '41 13 * * 1' |
There was a problem hiding this comment.
LOL, I always forget the format (github/codeql-action#242 😂); hopefully it gets added to the template at some point.
For others; this is 13:41, every Monday (once a week)
|
@caniszczyk Thanks! For future PRs, could you open the PR from a fork, instead of a branch on this repository? (trying to keep branches clean on the upstream repo) |
|
thanks will do, sorry about that!
…On Thu, Jan 28, 2021 at 4:12 PM Sebastiaan van Stijn < ***@***.***> wrote:
@caniszczyk <https://github.com/caniszczyk> Thanks! For future PRs, could
you open the PR from a fork, instead of a branch on this repository?
(trying to keep branches clean on the upstream repo)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3341 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPSINSPWBZGDOKXRS3U2TS4HOMVANCNFSM4WXOOBJQ>
.
--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1 512 961 6719
|
|
|
||
| # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). | ||
| # If this step fails, then you should remove it and run the build manually (see below) | ||
| - name: Autobuild |
There was a problem hiding this comment.
Autobuild is not needed as it does not work for Go
There was a problem hiding this comment.
@caniszczyk would you mind removing this bit, even though it's not needed as it can confuse folks. Once that's done let's merge this in.
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
A little security scanning doesn't hurt, let's start by adding one tool first: CodeQL via GH.
Signed-off-by: Chris Aniszczyk caniszczyk@gmail.com