Add docker image release workflow #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
chrispat
approved these changes
Mar 23, 2021
wy65701436
reviewed
Mar 24, 2021
.github/workflows/release.yaml
Outdated
| @@ -0,0 +1,60 @@ | |||
| name: Build release image and push to hub | |||
There was a problem hiding this comment.
the name will show in the action page, can we give a short one?
There was a problem hiding this comment.
Yes, we can! What would you suggest? Release Image?
There was a problem hiding this comment.
Release Image is OK, you can merge it after revise.
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secrets used in this workflow have been manually added by me to GitHub secrets on this repo. They will be changed once we sort out Docker Hub accounts and tokens, but the current creds work fine for pushing images to Docker Hub.
The idea is when we tag a release the image is automatically built from the tag ref and pushed to Docker Hub.
Signed-off-by: Milos Gajdos milosgajdos83@gmail.com