New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for tags list pagination #3422
Conversation
Signed-off-by: João Pereira <484633+joaodrp@users.noreply.github.com>
0b6bcc2
to
8ef268d
Compare
cc @eyJhb |
Codecov Report
@@ Coverage Diff @@
## main #3422 +/- ##
==========================================
+ Coverage 56.16% 56.36% +0.19%
==========================================
Files 102 102
Lines 7303 7303
==========================================
+ Hits 4102 4116 +14
+ Misses 2553 2538 -15
- Partials 648 649 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This kinda made me wonder if all those URLBuilder
methods should provide variadic url.Value
params in v3
.
Yes I understand that would mean breaking notifications.URLBuilder
, but since we've decided to break some interface in v3
we might as well do this.
That's a good point. However, do we have a use case (now or planned for the near future) for URL values in other methods that don't have them already? Exposing these before they're needed is counter-intuitive IMO. |
We don't actually, no. I was merely thinking out loud just in case the topic comes up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adds test coverage for #3143.