fix the /v2/_catalog n parameter description #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Please sign your commits as per the contributions guidelines. |
If `n` is not present only 100 entries returned Signed-off-by: lisong <lisong@cdsunrise.net>
Codecov Report
@@ Coverage Diff @@
## main #3425 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 102 102
Lines 7303 7303
=======================================
Hits 4102 4102
Misses 2553 2553
Partials 648 648 Continue to review full report at Codecov.
|
milosgajdos
approved these changes
Jun 15, 2021
joaodrp
requested changes
Jun 15, 2021
There was a problem hiding this comment.
@lostsquirrel, can you please update the descriptor as well?
Ideally, we should update the descriptor and then run:
./bin/registry-api-descriptor-template docs/spec/api.md.tmpl > docs/spec/api.md
This will take care of refreshing the API spec.
If `n` is not present only 100 entries returned Signed-off-by: lisong <lisong@cdsunrise.net>
|
@joaodrp done |
joaodrp
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
nis not present only 100 entries returned