Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: a client implementation #3435

Merged
merged 1 commit into from Jun 18, 2021
Merged

Conversation

yecril71pl
Copy link
Contributor

No description provided.

@milosgajdos
Copy link
Member

Please sign your commit as per contribution guidelines.

@yecril71pl
Copy link
Contributor Author

Please sign your commit as per contribution guidelines.

I tried, is this what you want?

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #3435 (7244cd3) into main (6d75bd0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3435   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files         102      102           
  Lines        7324     7324           
=======================================
  Hits         4130     4130           
  Misses       2541     2541           
  Partials      653      653           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d75bd0...7244cd3. Read the comment docs.

@milosgajdos
Copy link
Member

Your commit is still not signed. Please follow this https://github.com/distribution/distribution/blob/main/CONTRIBUTING.md#sign-your-work

@yecril71pl
Copy link
Contributor Author

Here is the exact instruction:

Then you just add a line to every git commit message:
Signed-off-by: Joe Smith joe.smith@email.com

There is 1 commit and the commit message contains the required line. What is missing?

@milosgajdos
Copy link
Member

If your read the DCO output from the GH action run you should see what the problem is.

Signed-off-by: Christopher Yeleighton <ne01026@shark.2a.pl>
@yecril71pl
Copy link
Contributor Author

If your read the DCO output from the GH action run you should see what the problem is.

Thank you. The problem was GitHub knows 2 my e-mail addresses for some reason (they are equivalent) but only one of them can be used for this purpose.

@joaodrp joaodrp merged commit a1e30cc into distribution:main Jun 18, 2021
@yecril71pl yecril71pl deleted the patch-1 branch June 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants