Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose Sargun as a maintainer #3441

Merged
merged 1 commit into from Aug 4, 2021

Conversation

justincormack
Copy link
Collaborator

Sargun is a large user of Distribution at Netflix, and is interested
in helping maintain, especially around storage drivers.

Please note as per Governance, this must be approved by 8 of the existing maintainers.

@justincormack
Copy link
Collaborator Author

cc @sargun

Sargun is a large user of Distribution at Netflix, and is interested
in helping maintain, especially around storage drivers.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #3441 (d3cd41a) into main (a1e30cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files         102      102           
  Lines        7324     7324           
=======================================
  Hits         4130     4130           
  Misses       2541     2541           
  Partials      653      653           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e30cc...d3cd41a. Read the comment docs.

Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sargun has done some great work

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justincormack
Copy link
Collaborator Author

Ok we have 7 maintainer approvals in GitHub plus me. Welcome @sargun

@justincormack justincormack merged commit 38ab4c6 into distribution:main Aug 4, 2021
@justincormack justincormack deleted the sargun branch August 4, 2021 10:49
dylanrhysscott pushed a commit to digitalocean/docker-distribution that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants