Fixing http status for PUT/PATCH APIs

[sudo-bmitch]

The PUT and PATCH requests should return 201 and 202 respectively.

Signed-off-by: Brandon Mitchell git@bmitch.net

[codecov-commenter]

Codecov Report

Merging #3444 (9c7967a) into main (ad8f5ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3444   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files         102      102           
  Lines        7324     7324           
=======================================
  Hits         4130     4130           
  Misses       2541     2541           
  Partials      653      653           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8f5ca...9c7967a. Read the comment docs.

[milosgajdos]

Attaching the URL to the spec for brevity: https://github.com/opencontainers/distribution-spec/blob/v1.0.0/spec.md

[wy65701436]

lgtm

[milosgajdos]

Thanks for stepping in and catching this one @joaodrp 😅 We really need to automate this somehow. @sudo-bmitch can you please address the code comments.

[sudo-bmitch]

@joaodrp any advice for how to handle paginationParameters?

distribution/registry/api/v2/descriptors.go

Line 98 in ad8f5ca

paginationParameters = []ParameterDescriptor{

It's used in tags:
https://github.com/distribution/distribution/blame/ad8f5caba068b2d4b83ba5a1c3e9d74e1da2c16e/docs/spec/api.md#L1509

and catalog:
https://github.com/distribution/distribution/blame/ad8f5caba068b2d4b83ba5a1c3e9d74e1da2c16e/docs/spec/api.md#L5484

with different values.

[sudo-bmitch]

The latest update leaves paginationParameters untouched and the tag/_catalog APIs that use it. Cleaning that up makes better sense for a separate PR.

[joaodrp]

@sudo-bmitch, thanks for the update. I agree that we should leave the pagination stuff for a separate PR. I raised an issue for it: #3445.

[joaodrp]

The checks that are failing here are also failing on main. I raised an issue to fix them (#3446).

I'd like to merge this now but can't as the failing conformance tests are required to pass. This is being discussed in #3442 (comment).

cc @sudo-bmitch