Fixed typo in error message #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3514 |
|
Can you sign your commit first @wyckster as per the contributor guideline? |
|
Thought I had it signed already. Is it better now? |
|
looks like you didn't use your real name ("Chad Faragher") in the sign off; but you may need to update your git config to also configure that name there (I think the DCO check checks against that) |
Codecov Report
@@ Coverage Diff @@
## main #3515 +/- ##
=======================================
Coverage 56.42% 56.42%
=======================================
Files 101 101
Lines 7282 7282
=======================================
Hits 4109 4109
Misses 2523 2523
Partials 650 650 Continue to review full report at Codecov.
|
milosgajdos
approved these changes
Oct 25, 2021
The wording of the error message had a typo (missing the word "not") that gave it the opposite meaning from the intended meaning. Signed-off-by: Chad Faragher <wyckster@hotmail.com>
|
@thaJeztah I'm sorry for the mistake with my signature. I believe I have fixed the problem. |
thaJeztah
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording of the error message had a typo (missing the word "not") that gave it the opposite meaning from the intended meaning.
Signed-off-by: Chad Faragher wyckster@hotmail.com