fix image cache incompletely #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justadogistaken
force-pushed
the
fix/image-cache-incomplete
branch
from
6bccd9a
to
f2801f5
Compare
|
/cc @milosgajdos |
milosgajdos
reviewed
Jan 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #3567 +/- ##
=======================================
Coverage 56.35% 56.36%
=======================================
Files 101 101
Lines 7307 7310 +3
=======================================
+ Hits 4118 4120 +2
- Misses 2534 2535 +1
Partials 655 655
Continue to review full report at Codecov.
|
Signed-off-by: baojiangnan <baojn1998@163.com>
justadogistaken
force-pushed
the
fix/image-cache-incomplete
branch
from
f2801f5
to
706f217
Compare
milosgajdos
approved these changes
Jan 14, 2022
|
/cc @wy65701436 |
|
/ptal @deleteriousEffect |
joaodrp
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #3438
I found there are some changes after v2.7.1. That is the context will be passed into http request. It may be closed before commit layer into local cache.
solved before:
solved:
