Explain important caveat in htpasswd tutorial #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2022
Signed-off-by: Radon Rosborough <radon.neon@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3630 +/- ##
=======================================
Coverage 56.33% 56.33%
=======================================
Files 101 101
Lines 7313 7313
=======================================
Hits 4120 4120
Misses 2536 2536
Partials 657 657 Continue to review full report at Codecov.
|
milosgajdos
approved these changes
Apr 17, 2022
thaJeztah
reviewed
Jun 21, 2022
| @@ -400,6 +400,12 @@ secrets. | |||
| > authentication to work. | |||
| {:.warning} | |||
|
|
|||
| > **Warning** | |||
| > The official registry image **only** supports htpasswd credentials in | |||
There was a problem hiding this comment.
does this apply only to the image or to the registry in general?
Somewhat wondering
- if we need to keep both of these as a "WARNING"; perhaps both should be a regular paragraph, describing what's supported and what not - which could be a table of supported hashing algorithms (there could be an extra line added to the "step 1." below.
- would there be a way for the registry to detect a mis-configured
htpasswdto prevent Private Registry "invalid authorization credential" appears, but everything works fine. #2817 (comment) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Documentation improvement. It took me almost an hour to track down #2817 (comment) as the reason my private Docker registry was not working, because of the lack of any error message pointing to the cause.
Related issues (optional)
Relates to #2817, but does not really solve it. In my opinion, a full solution to that issue would involve Docker Registry outputting a relevant error message when the incorrect credential type is used, rather than silently accepting it and then failing all login attempts.
This is a copy of docker/docs#14544 since per docker/docs#14544 (comment) this repository has the official reference docs, and the others are deprecated / will be removed.