S3 tests #3713
S3 tests #3713
Conversation
|
Rebased. For whatever reason, it seems I'm now considered a first time contributor again, so can I please have an OK to test? |
Mocking sounds good and I'm all for it but it merely covers unit tests - we need those indeed. I'm more keen on using some S3-compatible API we could stand up during the tests. Something like |
|
@Jamstah could you rebase, please |
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
If we haven't set a storage class there's no point in checking the storage class applied to the object - s3 will choose one. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
This test will only work on an s3 bucket on an s3 outpost. Most developers won't have access to one of these. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Other storage drivers will only return children and below, s3 should do the same. The only reason it was returning was because of the addition of a / to ensure we treat the from as a directory. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
|
Rebased |
|
I've looked at the code quickly but want to do so more in depth tomorrow before I add my review. Just wanted to let you know I am busy with it. |
|
Thanks David. A quick test run was ok for me but there have been quite a few changes since I wrote it. Be harsh, I don't take offense easily :) |
The s3 tests were failing for numerous reasons, so this PR fixes them.
Long term it would be better to mock the s3 SDK so that everyone could run them, and to run AWS connected tests in the CICD pipeline.