Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configuration.md #3898

Merged
merged 1 commit into from
May 9, 2023
Merged

Update configuration.md #3898

merged 1 commit into from
May 9, 2023

Conversation

ecormaksin
Copy link
Contributor

I think that valye is typo.

@milosgajdos
Copy link
Member

Can you please sign your DCO?

@ecormaksin @thaJeztah
Update configuration.md
5d301a9 
I think that `valye` is typo.

Signed-off-by: Makoto Oda <truth_jp_4133@yahoo.co.jp>
@thaJeztah
Copy link
Member

DCO looks good now; I did a quick rebase because there was a foreign commit in it

thaJeztah
thaJeztah approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit 2b13387 into distribution:main May 9, 2023
12 checks passed
@ecormaksin ecormaksin deleted the patch-1 branch May 11, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosgajdos milosgajdos milosgajdos approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ecormaksin @milosgajdos @thaJeztah