Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: fix filenames of artifacts #3910

Merged
merged 1 commit into from
May 9, 2023

Conversation

thaJeztah
Copy link
Member

No description provided.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@milosgajdos @corhere @squizzi ptal 🤗

Copy link
Collaborator

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously it's a tarball of a tarball, gzipped /s 😁

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (f55a655) 56.92% compared to head (435c7b9) 56.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3910      +/-   ##
==========================================
- Coverage   56.92%   56.88%   -0.05%     
==========================================
  Files         106      106              
  Lines       10703    10703              
==========================================
- Hits         6093     6088       -5     
- Misses       3938     3942       +4     
- Partials      672      673       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thaJeztah
Copy link
Member Author

Yeah, I highly suspect this was a copy/pasta from a release-pipeline of another repo that chose to use .tgz instead of .tar.gz. Either one is fine, but not "both" 😂

@thaJeztah
Copy link
Member Author

But the unfortunate (or perhaps fortunate) result was that the release uploaded only the .sha256 checksums, and not the actual binaries;

Screenshot 2023-05-10 at 00 35 25

@milosgajdos milosgajdos merged commit 8e29e87 into distribution:main May 9, 2023
12 checks passed
@thaJeztah thaJeztah deleted the fix_releaser_filenames branch May 9, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants