bump azure sdk #3916
Merged
bump azure sdk #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
==========================================
+ Coverage 56.88% 56.89% +0.01%
==========================================
Files 106 106
Lines 10703 10684 -19
==========================================
- Hits 6088 6079 -9
+ Misses 3942 3933 -9
+ Partials 673 672 -1 ☔ View full report in Codecov by Sentry. |
milosgajdos
approved these changes
May 15, 2023
|
I'm going to close this and reopen because I think the recent GH outage made DCO check stuck |
|
@flavianmissi you need to sign your commit |
flavianmissi
force-pushed
the
bump-azure-sdk
branch
from
088e377
to
cbd10fa
Compare
v1.3.0 of azidentity introduces support to workload identity. Signed-off-by: Flavian Missi <fmissi@redhat.com>
flavianmissi
force-pushed
the
bump-azure-sdk
branch
from
cbd10fa
to
7caf058
Compare
|
@wy65701436 are you able to help with review? |
corhere
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.3.0 of azidentity introduces support to workload identity.
Hi folks! I'm the team lead for OpenShift's internal image registry, and we're adding automagic support for azure workload identities.
The necessary work in the azure sdk was just release under v1.3.0.
I'd like us to upgrade to that version so that distribution can transparently support it.
According to the docs for
DefaultAzureCredential, things should just work (given some environment variables are set).Thanks!