Fix gcs storage driver #3929
Fix gcs storage driver #3929
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 56.88% 56.89% +0.01%
==========================================
Files 106 106
Lines 10703 10684 -19
==========================================
- Hits 6088 6079 -9
+ Misses 3942 3933 -9
+ Partials 673 672 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I'm LGTM-ing this as it's a port of #3702
I dont want this to be blocked for another year by unproductive conversations - we should look for perfection by iterating before v3 is released.
|
Who can help with the 2nd approval @milosgajdos ? |
|
CC: @distribution/maintainers |
both oss and gcs driver were missing the context parameter that is required to satisfy the storagedriver.FileWriter interface. Signed-off-by: Flavian Missi <fmissi@redhat.com>
Signed-off-by: Flavian Missi <fmissi@redhat.com>
Signed-off-by: Flavian Missi <fmissi@redhat.com>
Signed-off-by: Flavian Missi <fmissi@redhat.com>
flavianmissi
force-pushed
the
fix-gcs-oss-file-writer
branch
from
8ffa64a
to
817dd28
Compare
|
bumping this as it's still pending a review. |
|
great to see this getting merged! thanks to all for driving this effort 👏🏼 |
|
Big thanks go to @jmontleon for the initial effort and @flavianmissi for getting it across the finish line 🙇 |
|
Thank you @flavianmissi and @milosgajdos ! |
Based on #3702.
Also fixes the OSS
Cancelmethod which was missing a context parameter.