Remove oss storage driver and alicdn storage driver middleware #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `oss` storage driver from distribution as well as `alicdn` storage middleware which only works with the `oss` driver. There are several reasons for it: * no real-life expertise among the maintainers * oss is compatible with S3 API operations required by S3 storage driver Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
milosgajdos
requested review from
thaJeztah,
waynr,
wy65701436,
deleteriousEffect and
davidspek
3 tasks
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 110 110
Lines 11069 11069
=======================================
Hits 6183 6183
Misses 4193 4193
Partials 693 693 ☔ View full report in Codecov by Sentry. |
deleteriousEffect
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3982, also tracked in #3978.
This PR removes
ossstorage driver from distribution as well asalicdnstorage middleware which only works with theossdriver.There are several reasons for it:
This will also remove dependencies that are also hard to keep up with.
NOTE: OSS is S3 compatible (see https://www.alibabacloud.com/help/en/oss/developer-reference/compatibility-with-amazon-s3) so users should consider relying on that