Update github.com/hashicorp/golang-lru to v2 #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidspek
requested review from
corhere,
milosgajdos,
thaJeztah,
wy65701436 and
deleteriousEffect
milosgajdos
reviewed
Aug 17, 2023
|
oh! could you squash the commits? |
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
davidspek
force-pushed
the
update-golang-lru
branch
from
1284e4c
to
0f00654
Compare
|
@thaJeztah Done :) |
milosgajdos
approved these changes
Aug 17, 2023
|
@thaJeztah PTAL 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
github.com/hashicorp/golang-lruto v2 which uses Go generics. I'm not very familiar with the code so this requires some experienced eyes but I believe I figured out the correct changes for the bump to v2.